linux-kernel - Re: [PATCH] EDAC/ti: Remove redundant error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Oct 2021 19:48:54 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     kristo@...nel.org, mchehab@...nel.org, tony.luck@...el.com,
        james.morse@....com, rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/ti: Remove redundant error messages

On Wed, Aug 11, 2021 at 07:26:26PM +0800, Tang Bin wrote:
> In the function ti_edac_probe, devm_ioremap_resource() and
> platform_get_irq() have already contains error message, so
> remove the redundant error messages.
> 
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
>  drivers/edac/ti_edac.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/ti_edac.c b/drivers/edac/ti_edac.c
> index 169f96e51..6971ded59 100644
> --- a/drivers/edac/ti_edac.c
> +++ b/drivers/edac/ti_edac.c
> @@ -245,11 +245,8 @@ static int ti_edac_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	reg = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(reg)) {
> -		edac_printk(KERN_ERR, EDAC_MOD_NAME,
> -			    "EMIF controller regs not defined\n");
> +	if (IS_ERR(reg))
>  		return PTR_ERR(reg);
> -	}
>  
>  	layers[0].type = EDAC_MC_LAYER_ALL_MEM;
>  	layers[0].size = 1;
> @@ -281,8 +278,6 @@ static int ti_edac_probe(struct platform_device *pdev)
>  	error_irq = platform_get_irq(pdev, 0);
>  	if (error_irq < 0) {
>  		ret = error_irq;
> -		edac_printk(KERN_ERR, EDAC_MOD_NAME,
> -			    "EMIF irq number not defined.\n");
>  		goto err;
>  	}
>  
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette