linux-kernel - Re: [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Oct 2021 00:09:46 +0000
From:   Nick Terrell <terrelln@...com>
To:     kernel test robot <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "Linux Memory Management List" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH linux-next] lib: zstd: fix duplicated inclusion



> On Oct 7, 2021, at 4:27 PM, kernel test robot <lkp@...el.com> wrote:
> 
> Generated by: scripts/checkincludes.pl
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
> debug.h |    1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/lib/zstd/common/debug.h b/lib/zstd/common/debug.h
> index 6dd88d1fbd02c..c8dc0b1890369 100644
> --- a/lib/zstd/common/debug.h
> +++ b/lib/zstd/common/debug.h
> @@ -65,7 +65,6 @@
> 
> #if (DEBUGLEVEL>=1)
> #  define ZSTD_DEPS_NEED_ASSERT
> -#  include "zstd_deps.h"
> #else
> #  ifndef assert   /* assert may be already defined, due to prior #include <assert.h> */
> #    define assert(condition) ((void)0)   /* disable assert (default) */

This is an intentional design choice of upstream zstd, and is correct.

Defining ZSTD_DEPS_NEED_ASSERT will cause “zstd_deps.h” to
provide a definition of assert(), even if it has already been included.

-Nick