linux-kernel - Re: [PATCH 0/5] Switchtec Fixes and Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211008170550.GA1352932@bhelgaas>
Date:   Fri, 8 Oct 2021 12:05:50 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     kelvin.cao@...rochip.com
Cc:     kurt.schwemmer@...rosemi.com, logang@...tatee.com,
        bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kelvincao@...look.com
Subject: Re: [PATCH 0/5] Switchtec Fixes and Improvements

On Fri, Sep 24, 2021 at 11:08:37AM +0000, kelvin.cao@...rochip.com wrote:
> From: Kelvin Cao <kelvin.cao@...rochip.com>
> 
> Hi,
> 
> Please find a bunch of patches for the switchtec driver collected over the
> last few months.

Question: Is there a reason this driver should be in drivers/pci/?

It doesn't use any internal PCI core interfaces, e.g., it doesn't
include drivers/pci/pci.h, and AFAICT it's really just a driver for a
PCI device that happens to be a switch.

I don't really *care* that it's in drivers/pci; I rely on Kurt and
Logan to review changes.  The only problem it presents for me is that
I have to write merge commit logs for the changes.  You'd think that
would be trivial, but since I don't know much about the driver, it
does end up being work for me.

Bjorn