lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Oct 2021 15:44:27 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Jiri Olsa <jolsa@...hat.com> Cc: "Bayduraev, Alexey V" <alexey.v.bayduraev@...ux.intel.com>, Namhyung Kim <namhyung@...nel.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, linux-kernel <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...ux.intel.com>, Adrian Hunter <adrian.hunter@...el.com>, Alexander Antonov <alexander.antonov@...ux.intel.com>, Alexei Budankov <abudankov@...wei.com>, Riccardo Mancini <rickyman7@...il.com> Subject: Re: [PATCH] perf report: Output non-zero offset for decompressed records Em Mon, Oct 04, 2021 at 09:06:36AM +0200, Jiri Olsa escreveu: > On Mon, Oct 04, 2021 at 10:00:52AM +0300, Bayduraev, Alexey V wrote: > > On 04.10.2021 9:42, Jiri Olsa wrote: > > > On Wed, Sep 29, 2021 at 12:14:45PM +0300, Alexey Bayduraev wrote: > > >> Print offset of PERF_RECORD_COMPRESSED record instead of zero for > > >> decompressed records in raw trace dump (-D option of perf-report): > > >> 0x17cf08 [0x28]: event: 9 > > >> instead of: > > >> 0 [0x28]: event: 9 > > >> The fix is not critical, because currently file_pos for compressed > > >> events is used in perf_session__process_event only to show offsets > > >> in the raw dump. > > > I don't mind the change just curious, because I see also: > > > > > > perf_session__process_event > > > perf_session__process_user_event > > > lseek(fd, file_offset, ... > > > which is not raw dump as the comment suggests > > Yes, but this "lseek" only works for user events, whereas the > > PERF_RECORD_COMPRESSED record shouln't contain such events. > > Currently, the PERF_RECORD_COMPRESSED container can only pack > > kernel events. > Acked-by: Jiri Olsa <jolsa@...hat.com> Thanks, applied. - Arnaldo
Powered by blists - more mailing lists