linux-kernel - Re: [PATCH v2 1/2] PCI: hv: Make the code arch neutral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Oct 2021 14:16:52 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Sunil Muthuswamy <sunilmut@...rosoft.com>
Cc:     Marc Zyngier <maz@...nel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Boqun Feng <Boqun.Feng@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof Wilczyński" <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Wei Liu <wei.liu@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "\"H. Peter Anvin\"" <hpa@...or.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] PCI: hv: Make the code arch neutral

Can you put some specifics in the subject line, please?  If this patch
does several things, that might be an indication that it should be
split into several patches.

On Fri, Oct 08, 2021 at 05:20:35PM +0000, Sunil Muthuswamy wrote:
> This patch makes the Hyper-V vPCI code architectural neutral by
> introducing an irqchip that takes care of architectural
> dependencies. This allows for the implementation of Hyper-V vPCI
> for other architecture such as ARM64.

No need to include "This patch"; we already know we're talking about
this patch.

Write in "imperative mood", e.g., "Encapsulate arch dependencies in
X ..." instead of "This patch makes the code ...".  See
https://chris.beams.io/posts/git-commit/

Wrap the text to fill 75 columns.

You said this "introduces an irqchip", but I don't see a new
struct irq_chip or similar.

The important part about making this arch-neutral seems to be adding
these interfaces that will encapsulate arch dependencies:

  hv_pci_irqchip_init()
  hv_pci_irqchip_free()
  hv_msi_get_int_vector()
  hv_set_msi_entry_from_desc()
  hv_msi_prepare()

I'm not sure wrapping them in "#ifdef CONFIG_X86_64" is the best
approach, but the IRQ folks will know better.

> +++ b/drivers/pci/controller/pci-hyperv-irqchip.c
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: GPL-2.0
> +

Spurious blank line (follow style of nearby files).

> +/*
> + * Hyper-V vPCI irqchip.

> +++ b/drivers/pci/controller/pci-hyperv-irqchip.h
> @@ -0,0 +1,21 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +

Spurious blank line (follow style of nearby files).

> +/*
> + * Architecture specific vector management for the Hyper-V vPCI.