linux-kernel - Re: [PATCH] iio/scmi: check if dev is null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4ccc9c0-c852-1c40-d0a1-70298b6b34c2@metafoo.de>
Date:   Fri, 8 Oct 2021 11:01:42 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, jbhayana@...gle.com,
        jic23@...nel.org
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio/scmi: check if dev is null pointer

On 10/8/21 8:29 AM, Jiasheng Jiang wrote:
> The parameter 'dev' of scmi_iio_dev_probe() isn't been
> checked before used, including when scmi_iio_dev_probe() is called.
> Therefore, it might be better to check, just in case.
>
> Fixes: 25cbdd4 ("iio/scmi: Port driver to the new scmi_sensor_proto_ops interface")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Hi,

Thanks for the patch.

Is there anything that makes you think dev could ever be NULL? dev is a 
pointer to a field in `sdev`. So for `dev` to be NULL sdev would have to 
be `-offsetof(struct scmi_device, dev)`.


- Lars

> ---
>   drivers/iio/common/scmi_sensors/scmi_iio.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/common/scmi_sensors/scmi_iio.c b/drivers/iio/common/scmi_sensors/scmi_iio.c
> index 141e8aa..d3ff985 100644
> --- a/drivers/iio/common/scmi_sensors/scmi_iio.c
> +++ b/drivers/iio/common/scmi_sensors/scmi_iio.c
> @@ -592,6 +592,9 @@ static int scmi_iio_dev_probe(struct scmi_device *sdev)
>   
>   	if (!handle)
>   		return -ENODEV;
> +
> +	if (!dev)
> +		return -ENODEV;
>   
>   	sensor_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_SENSOR, &ph);
>   	if (IS_ERR(sensor_ops)) {