linux-kernel - Re: [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with SPDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 08 Oct 2021 03:54:53 -0700
From:   Joe Perches <joe@...ches.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Krzysztof Opasiak <k.opasiak@...sung.com>,
        Mark Greer <mgreer@...malcreek.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-nfc@...ts.01.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with
 SPDX

On Fri, 2021-10-08 at 12:46 +0200, Krzysztof Kozlowski wrote:
> On 08/10/2021 12:33, Joe Perches wrote:
> > On Thu, 2021-10-07 at 15:30 +0200, Krzysztof Kozlowski wrote:
> > > Replace standard GPLv2 only license text with SPDX tag.
> > 
> > Nak
> > 
> > This is actually licenced with GPL-2.0-or-later
> > 
> > > diff --git a/net/nfc/nci/uart.c b/net/nfc/nci/uart.c
> > []
> > > @@ -1,20 +1,8 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > []
> > You may use, redistribute and/or modify this File in
> > > - * accordance with the terms and conditions of the License, a copy of which
> > > - * is available on the worldwide web at
> > > - * http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
> > 
> > See the actual text at the old link which includes:
> > 
> >     This program is free software; you can redistribute it and/or modify
> >     it under the terms of the GNU General Public License as published by
> >     the Free Software Foundation; either version 2 of the License, or
> >     (at your option) any later version.
> 
> 
> Thanks Joe for checking this. Isn't this conflicting with first
> paragraph in the source file:
> 
>   This software file (the "File") is distributed by Marvell
> InternationalLtd. under the terms of the GNU General Public License
> Version 2, June 1991(the "License").
> 
> This part does not specify "or later".

It doesn't need to as it calls out the exact license which by
specific reference includes the "or later".

And this is a nominal 'weakness' in the spdx license referencing
system which relies on contents of files in the LICENSE directory.