linux-kernel - Re: [PATCH] mm: Free per cpu pages async to shorten program exit time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Oct 2021 19:27:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     ultrachin@....com, akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, brookxu.cn@...il.com,
        chen xiaoguang <xiaoggchen@...cent.com>,
        zeng jingxiang <linuszeng@...cent.com>,
        lu yihui <yihuilu@...cent.com>
Subject: Re: [PATCH] mm: Free per cpu pages async to shorten program exit time

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.15-rc4]
[cannot apply to hnaz-mm/master next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/ultrachin-163-com/mm-Free-per-cpu-pages-async-to-shorten-program-exit-time/20211008-145835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5816b3e6577eaa676ceb00a848f0fd65fe2adc29
config: nios2-randconfig-r004-20211008 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3e55b36596eb3a798c6f649e5e1c0f5eac8522b3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review ultrachin-163-com/mm-Free-per-cpu-pages-async-to-shorten-program-exit-time/20211008-145835
        git checkout 3e55b36596eb3a798c6f649e5e1c0f5eac8522b3
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/exit.c: In function 'delayed_put_task_struct':
>> kernel/exit.c:170:31: error: 'struct task_struct' has no member named 'cpu'
     170 |         unsigned int cpu = tsk->cpu;
         |                               ^~
   kernel/exit.c: At top level:
   kernel/exit.c:1812:13: warning: no previous prototype for 'abort' [-Wmissing-prototypes]
    1812 | __weak void abort(void)
         |             ^~~~~


vim +170 kernel/exit.c

   166	
   167	static void delayed_put_task_struct(struct rcu_head *rhp)
   168	{
   169		struct task_struct *tsk = container_of(rhp, struct task_struct, rcu);
 > 170		unsigned int cpu = tsk->cpu;
   171	
   172		perf_event_delayed_put(tsk);
   173		trace_sched_process_free(tsk);
   174		put_task_struct(tsk);
   175		kfreepcp_set_run(cpu);
   176	}
   177	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34014 bytes)