linux-kernel - Re: [PATCH v3 2/2] ASoC: rt9120: Add rt9210 audio amplifier support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWA+ykStTEyzRbEy@sirena.org.uk>
Date:   Fri, 8 Oct 2021 13:51:22 +0100
From:   Mark Brown <broonie@...nel.org>
To:     cy_huang <u0084500@...il.com>
Cc:     oder_chiou@...ltek.com, perex@...ex.cz, tiwai@...e.com,
        robh+dt@...nel.org, lgirdwood@...il.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        cy_huang@...htek.com, devicetree@...r.kernel.org,
        allen_lin@...htek.com
Subject: Re: [PATCH v3 2/2] ASoC: rt9120: Add rt9210 audio amplifier support

On Fri, Oct 08, 2021 at 12:50:12PM +0800, cy_huang wrote:

> +static const struct snd_kcontrol_new rt9120_snd_controls[] = {
> +	SOC_SINGLE_TLV("MS Volume", RT9120_REG_MSVOL, 0, 2047, 1, digital_gain),
> +	SOC_SINGLE("SPK Gain", RT9120_REG_SPKGAIN, 0, 7, 0),

Volume controls should end in Volume even if they don't have TLV
information so applications know how to render them.  I'll fix
this up as I apply.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)