linux-kernel - Re: [PATCH] libperf test: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Oct 2021 15:09:03 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Shunsuke Nakamura <nakamura.shun@...itsu.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] libperf test: Fix build error

On Wed, Oct 06, 2021 at 06:57:03PM +0900, Shunsuke Nakamura wrote:
> In test_stat_user_read, following build error occurs except i386 and 
> x86_64 architectures:
> 
> tests/test-evsel.c:129:31: error: variable 'pc' set but not used [-Werror=unused-but-set-variable]
>   struct perf_event_mmap_page *pc;
> 
> Fix build error.
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@...itsu.com>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
>  tools/lib/perf/tests/test-evsel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/lib/perf/tests/test-evsel.c b/tools/lib/perf/tests/test-evsel.c
> index a184e4861627..9abd4c0bf6db 100644
> --- a/tools/lib/perf/tests/test-evsel.c
> +++ b/tools/lib/perf/tests/test-evsel.c
> @@ -148,6 +148,7 @@ static int test_stat_user_read(int event)
>  	__T("failed to mmap evsel", err == 0);
>  
>  	pc = perf_evsel__mmap_base(evsel, 0, 0);
> +	__T("failed to get mmapped address", pc);
>  
>  #if defined(__i386__) || defined(__x86_64__)
>  	__T("userspace counter access not supported", pc->cap_user_rdpmc);
> -- 
> 2.25.1
>