linux-kernel - Re: [PATCH v2 4/4] iio: light: noa1305: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211008020950.GA290@LAPTOP-UKSR4ENP.internal.baidu.com>
Date:   Fri, 8 Oct 2021 10:09:50 +0800
From:   Cai Huoqing <caihuoqing@...du.com>
To:     Jonathan Cameron <jic23@...nel.org>
CC:     Kevin Tsai <ktsai@...ellamicro.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] iio: light: noa1305: Make use of the helper
 function dev_err_probe()

On 07 10月 21 18:38:26, Jonathan Cameron wrote:
> On Tue, 28 Sep 2021 09:41:55 +0800
> Cai Huoqing <caihuoqing@...du.com> wrote:
> 
> > When possible use dev_err_probe help to properly deal with the
> > PROBE_DEFER error, the benefit is that DEFER issue will be logged
> > in the devices_deferred debugfs file.
> > Using dev_err_probe() can reduce code size, and the error value
> > gets printed.
> > 
> > Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> Applied this patch to the togreg branch of iio.git and pushed out as
> testing for 0-day to try it out.
> 
> Note I didn't pick up 1 and 3 from this series and will expect to see
> a v3 of those or reply to the relevant reviews.
Sure, I will resend some patches according to your feedback.
Just took my vacation during 1~7th Oct.
> 
> Thanks,
> 
> Jonathan
> 
> > ---
> > v1->v2: Remove the separate line of PTR_ERR().
> > 
> >  drivers/iio/light/noa1305.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
> > index a308fbc2fc7b..71a322227429 100644
> > --- a/drivers/iio/light/noa1305.c
> > +++ b/drivers/iio/light/noa1305.c
> > @@ -217,10 +217,9 @@ static int noa1305_probe(struct i2c_client *client,
> >  	priv = iio_priv(indio_dev);
> >  
> >  	priv->vin_reg = devm_regulator_get(&client->dev, "vin");
> > -	if (IS_ERR(priv->vin_reg)) {
> > -		dev_err(&client->dev, "get regulator vin failed\n");
> > -		return PTR_ERR(priv->vin_reg);
> > -	}
> > +	if (IS_ERR(priv->vin_reg))
> > +		return dev_err_probe(&client->dev, PTR_ERR(priv->vin_reg),
> > +				     "get regulator vin failed\n");
> >  
> >  	ret = regulator_enable(priv->vin_reg);
> >  	if (ret) {
>