linux-kernel - Re: [v3,7/9] dt-bindings: arm64: dts: mediatek: Add mt7986 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc29d5bc-9ce7-6147-a708-e6304249b600@gmail.com>
Date:   Fri, 8 Oct 2021 15:53:16 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Sam Shih <sam.shih@...iatek.com>
Cc:     Ryder.Lee@...iatek.com, devicetree@...r.kernel.org,
        enric.balletbo@...labora.com, fparent@...libre.com,
        gregkh@...uxfoundation.org, herbert@...dor.apana.org.au,
        hsinyi@...omium.org, john@...ozen.org, linus.walleij@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-serial@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux@...ck-us.net, mpm@...enic.com, mturquette@...libre.com,
        robh+dt@...nel.org, sboyd@...nel.org, sean.wang@...nel.org,
        seiya.wang@...iatek.com, wim@...ux-watchdog.org
Subject: Re: [v3,7/9] dt-bindings: arm64: dts: mediatek: Add mt7986 series

Hi Sam,

I'd advise to split this series in parts for:
- basic device support via dts.
- pinctrl driver + dts
- clk driver + dts

I would also advise to not send new versions of patches as new threads and don't 
respond in the same thread. At least for me that breaks my workflow as I use b4.

Regards,
Matthias


On 24/09/2021 13:40, Sam Shih wrote:
> MT7986 series is Mediatek's new 4-core SoC, which is mainly for
> wifi-router application. The difference between mt7986a and mt7986b
> is that some pins do not exist on mt7986b.
> 
> Signed-off-by: Sam Shih <sam.shih@...iatek.com>
> Acked-by: Rob Herring <robh@...nel.org>
> 
> ---
> v3: changed 'MT7986' to 'MT7986 series' in the commit message
> v2: added an Acked-by tag
> ---
>   Documentation/devicetree/bindings/arm/mediatek.yaml | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 80a05f6fee85..a9a778269684 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -76,6 +76,14 @@ properties:
>             - enum:
>                 - mediatek,mt7629-rfb
>             - const: mediatek,mt7629
> +      - items:
> +          - enum:
> +              - mediatek,mt7986a-rfb
> +          - const: mediatek,mt7986a
> +      - items:
> +          - enum:
> +              - mediatek,mt7986b-rfb
> +          - const: mediatek,mt7986b
>         - items:
>             - enum:
>                 - mediatek,mt8127-moose
>