linux-kernel - Re: [PATCH] platform: dell: all DELL_WMI driver options depend on DELL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79b874ba-7d69-7dff-69d3-f09b4e0f2b39@infradead.org>
Date:   Fri, 8 Oct 2021 07:49:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Perry Yuan <Perry.Yuan@...l.com>, Dell.Client.Kernel@...l.com,
        platform-driver-x86@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>
Subject: Re: [PATCH] platform: dell: all DELL_WMI driver options depend on
 DELL_WMI

Still seeing this build error in linux-next, so the patch
is still needed...

On 9/27/21 1:53 PM, Randy Dunlap wrote:
> A randconfig or a user can set/enable DELL_WMI_PRIVACY even when
> DELL_WMI is not enabled. This leads to a build error in
> dell-laptop.o:
> 
> ld: drivers/platform/x86/dell/dell-laptop.o: in function `dell_init':
> dell-laptop.c:(.init.text+0x719): undefined reference to `dell_privacy_has_mic_mute'
> 
> Fix this by enclosing the DELL_WMI driver options inside a
> if DELL_WMI / endif bracket.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Perry Yuan <Perry.Yuan@...l.com>
> Cc: Dell.Client.Kernel@...l.com
> Cc: platform-driver-x86@...r.kernel.org
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Mark Gross <mgross@...ux.intel.com>
> ---
> Found in linux-next, applies to mainline.
> 
> The last time that I sent a patch to Perry Yuan (about 2 weeks ago),
> it bounced...
> 
>   drivers/platform/x86/dell/Kconfig |    4 ++++
>   1 file changed, 4 insertions(+)
> 
> --- linux-next-20210927.orig/drivers/platform/x86/dell/Kconfig
> +++ linux-next-20210927/drivers/platform/x86/dell/Kconfig
> @@ -164,6 +164,8 @@ config DELL_WMI
>   	  To compile this driver as a module, choose M here: the module will
>   	  be called dell-wmi.
>   
> +if DELL_WMI
> +
>   config DELL_WMI_PRIVACY
>   	bool "Dell WMI Hardware Privacy Support"
>   	depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO
> @@ -198,6 +200,8 @@ config DELL_WMI_LED
>   	  This adds support for the Latitude 2100 and similar
>   	  notebooks that have an external LED.
>   
> +endif # DELL_WMI
> +
>   config DELL_WMI_SYSMAN
>   	tristate "Dell WMI-based Systems management driver"
>   	default m
> 


-- 
~Randy