| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202110091005.ONsQqLyg-lkp@intel.com>
Date: Sat, 9 Oct 2021 10:17:15 +0800
From: kernel test robot <lkp@...el.com>
To: "Ahmed S. Darwish" <a.darwish@...utronix.de>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: [rt-devel:linux-5.15.y-rt-rebase 62/155] net/sched/sch_gred.c:350:1:
warning: the frame size of 1164 bytes is larger than 1024 bytes
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.15.y-rt-rebase
head: d2f311fe375d0cf3b1f03bae1251036c93741332
commit: 2b93dab38e67ca2c37938cea1ce007e6a74f4365 [62/155] net: sched: Protect Qdisc::bstats with u64_stats
config: openrisc-randconfig-r031-20211008 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/commit/?id=2b93dab38e67ca2c37938cea1ce007e6a74f4365
git remote add rt-devel https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git
git fetch --no-tags rt-devel linux-5.15.y-rt-rebase
git checkout 2b93dab38e67ca2c37938cea1ce007e6a74f4365
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
net/sched/sch_gred.c: In function 'gred_offload':
>> net/sched/sch_gred.c:350:1: warning: the frame size of 1164 bytes is larger than 1024 bytes [-Wframe-larger-than=]
350 | }
| ^
vim +350 net/sched/sch_gred.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 309
890d8d23ec3c9e Jakub Kicinski 2018-11-19 310 static void gred_offload(struct Qdisc *sch, enum tc_gred_command command)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 311 {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 312 struct gred_sched *table = qdisc_priv(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 313 struct net_device *dev = qdisc_dev(sch);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 314 struct tc_gred_qopt_offload opt = {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 315 .command = command,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 316 .handle = sch->handle,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 317 .parent = sch->parent,
890d8d23ec3c9e Jakub Kicinski 2018-11-19 318 };
890d8d23ec3c9e Jakub Kicinski 2018-11-19 319
890d8d23ec3c9e Jakub Kicinski 2018-11-19 320 if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 321 return;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 322
890d8d23ec3c9e Jakub Kicinski 2018-11-19 323 if (command == TC_GRED_REPLACE) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 324 unsigned int i;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 325
890d8d23ec3c9e Jakub Kicinski 2018-11-19 326 opt.set.grio_on = gred_rio_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 327 opt.set.wred_on = gred_wred_mode(table);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 328 opt.set.dp_cnt = table->DPs;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 329 opt.set.dp_def = table->def;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 330
890d8d23ec3c9e Jakub Kicinski 2018-11-19 331 for (i = 0; i < table->DPs; i++) {
890d8d23ec3c9e Jakub Kicinski 2018-11-19 332 struct gred_sched_data *q = table->tab[i];
890d8d23ec3c9e Jakub Kicinski 2018-11-19 333
890d8d23ec3c9e Jakub Kicinski 2018-11-19 334 if (!q)
890d8d23ec3c9e Jakub Kicinski 2018-11-19 335 continue;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 336 opt.set.tab[i].present = true;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 337 opt.set.tab[i].limit = q->limit;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 338 opt.set.tab[i].prio = q->prio;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 339 opt.set.tab[i].min = q->parms.qth_min >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 340 opt.set.tab[i].max = q->parms.qth_max >> q->parms.Wlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 341 opt.set.tab[i].is_ecn = gred_use_ecn(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 342 opt.set.tab[i].is_harddrop = gred_use_harddrop(q);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 343 opt.set.tab[i].probability = q->parms.max_P;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 344 opt.set.tab[i].backlog = &q->backlog;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 345 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 346 opt.set.qstats = &sch->qstats;
890d8d23ec3c9e Jakub Kicinski 2018-11-19 347 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 348
890d8d23ec3c9e Jakub Kicinski 2018-11-19 349 dev->netdev_ops->ndo_setup_tc(dev, TC_SETUP_QDISC_GRED, &opt);
890d8d23ec3c9e Jakub Kicinski 2018-11-19 @350 }
890d8d23ec3c9e Jakub Kicinski 2018-11-19 351
:::::: The code at line 350 was first introduced by commit
:::::: 890d8d23ec3c9eca847be0593c0cf5f650b97271 net: sched: gred: add basic Qdisc offload
:::::: TO: Jakub Kicinski <jakub.kicinski@...ronome.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (31356 bytes)
Powered by blists - more mailing lists