linux-kernel - Re: [PATCH net-next -v5 4/4] skbuff: keep track of pp page when pp_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202110092025.WBe9HqiX-lkp@intel.com>
Date:   Sat, 9 Oct 2021 20:12:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...neuler.org,
        akpm@...ux-foundation.org, hawk@...nel.org,
        ilias.apalodimas@...aro.org, peterz@...radead.org,
        yuzhao@...gle.com
Subject: Re: [PATCH net-next -v5 4/4] skbuff: keep track of pp page when
 pp_frag_count is used

Hi Yunsheng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yunsheng-Lin/some-optimization-for-page-pool/20211009-174023
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f12e658c620a925aba4caead54a05eb157728863
config: i386-randconfig-a001-20211009 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d58490b58ef2cfa172d5e1ff2d13b713a6d38969
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yunsheng-Lin/some-optimization-for-page-pool/20211009-174023
        git checkout d58490b58ef2cfa172d5e1ff2d13b713a6d38969
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: net/core/skbuff.o: in function `skb_free_head':
>> net/core/skbuff.c:653: undefined reference to `page_pool_return_skb_page'


vim +653 net/core/skbuff.c

   643	
   644	static void skb_free_head(struct sk_buff *skb)
   645	{
   646		unsigned char *head = skb->head;
   647	
   648		if (skb->head_frag) {
   649			struct page *page = virt_to_head_page(head);
   650	
   651			if (page_pool_is_pp_page(page) &&
   652			    (skb->pp_recycle || page_pool_is_pp_page_frag(page))) {
 > 653				page_pool_return_skb_page(page);
   654				return;
   655			}
   656	
   657			__page_frag_cache_drain(page, 1);
   658		} else {
   659			kfree(head);
   660		}
   661	}
   662	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (34063 bytes)