linux-kernel - Re: [net-next PATCH v2 06/15] dt-bindings: net: dsa: qca8k: document rgmii_1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWHRbs8KCJ2XrF65@lunn.ch>
Date:   Sat, 9 Oct 2021 19:29:18 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v2 06/15] dt-bindings: net: dsa: qca8k: document
 rgmii_1_8v bindings

> > Are ipq8065 & ipq8064 SoCs which the switch is embedded into? So you
> > could look for the top level compatible and set these regulators based
> > on that. No DT property needed.
> > 
> >    Andrew
> 
> The switch is still external for these 2 SoC. If we really want, yes we
> can follow that route and sets only for the 2 SoC. (Considering ipq8065
> is still not present, can I add it anyway in the qca8k code? Will for
> sure propose the ipq8065 dtsi today)

It seems like this is less error prone. If the properties really are
needed, because somebody creates a board with swapped SoC and Switch,
the properties can be added later.

    Andrew