[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YWIiuVSeAsvZEEUx@Ansuel-xps.localdomain>
Date: Sun, 10 Oct 2021 01:16:09 +0200
From: Ansuel Smith <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH v2 13/15] dt-bindings: net: dsa: qca8k: document
open drain binding
On Sat, Oct 09, 2021 at 07:20:49PM +0200, Andrew Lunn wrote:
> On Fri, Oct 08, 2021 at 02:22:23AM +0200, Ansuel Smith wrote:
> > Document new binding qca,power_on_sel used to enable Power-on-strapping
> > select reg and qca,led_open_drain to set led to open drain mode.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> > ---
> > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > index b9cccb657373..9fb4db65907e 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > @@ -13,6 +13,17 @@ Required properties:
> > Optional properties:
> >
> > - reset-gpios: GPIO to be used to reset the whole device
> > +- qca,ignore-power-on-sel: Ignore power on pin strapping to configure led open
> > + drain or eeprom presence.
>
> So strapping is only used for LEDs and EEPROM presence? Nothing else?
> Seems link MAC0/MAC6 swap would be a good candidate for strapping?
>
> I just want to make it clear that if you select this option, you need
> to take care of X, Y and Z in DT.
>
> Andrew
Sorry I missed this. Yes strapping is used only for LEDs and EEPROM. No
reference in Documentation about mac swap. Other strapping are related
to voltage selection and other hardware stuff. Thing that can't be set
from sw.
--
Ansuel
Powered by blists - more mailing lists