[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 10 Oct 2021 15:07:28 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Ansuel Smith <ansuelsmth@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Matthew Hagan <mnhagan88@...il.com>
Subject: Re: [net-next PATCH v4 03/13] dt-bindings: net: dsa: qca8k: Add MAC
swap and clock phase properties
On Sun, Oct 10, 2021 at 01:15:46PM +0200, Ansuel Smith wrote:
> Add names and descriptions of additional PORT0_PAD_CTRL properties.
> qca,sgmii-(rx|tx)clk-falling-edge are for setting the respective clock
> phase to failling edge.
>
> Signed-off-by: Matthew Hagan <mnhagan88@...il.com>
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
> Documentation/devicetree/bindings/net/dsa/qca8k.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> index 8c73f67c43ca..cc214e655442 100644
> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> @@ -37,6 +37,10 @@ A CPU port node has the following optional node:
> managed entity. See
> Documentation/devicetree/bindings/net/fixed-link.txt
> for details.
> +- qca,sgmii-rxclk-falling-edge: Set the receive clock phase to falling edge.
> + Mostly used in qca8327 with CPU port 0 set to
> + sgmii.
> +- qca,sgmii-txclk-falling-edge: Set the transmit clock phase to falling edge.
>
> For QCA8K the 'fixed-link' sub-node supports only the following properties:
>
> --
> 2.32.0
>
Must first document, then use.
Also, would you care converting qca8k.txt to qca8k.yaml?
Powered by blists - more mailing lists