linux-kernel - Re: [PATCH] staging: rtl8723bs: hal: remove duplicate check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 14:45:21 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Saurav Girepunje <saurav.girepunje@...il.com>,
        gregkh@...uxfoundation.org, fabioaiuto83@...il.com,
        marcocesati@...il.com, dan.carpenter@...cle.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     saurav.girepunje@...mail.com
Subject: Re: [PATCH] staging: rtl8723bs: hal: remove duplicate check

Hi,

On 10/10/21 9:08 AM, Saurav Girepunje wrote:
> Remove 'bPerformance' from if condition check. As on previous
> if condition it is already check for same variable.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@...il.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> ---
>  drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> index beda7b8a7c6a..7e92c373cddb 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> @@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
>  	/* 1 Adjust initial gain by false alarm */
>  	if (pDM_Odm->bLinked && bPerformance) {
> 
> -		if (bFirstTpTarget || (FirstConnect && bPerformance)) {
> +		if (bFirstTpTarget || FirstConnect) {
>  			pDM_DigTable->LargeFAHit = 0;
> 
>  			if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
> --
> 2.32.0
>