lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 10 Oct 2021 15:50:02 +0300
From:   Vladimir Oltean <>
To:     Ansuel Smith <>
Cc:     Andrew Lunn <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        Rob Herring <>,
        Russell King <>,,,,
        Matthew Hagan <>
Subject: Re: [net-next PATCH v4 02/13] net: dsa: qca8k: add support for sgmii
 falling edge

On Sun, Oct 10, 2021 at 02:10:00PM +0200, Ansuel Smith wrote:
> > I would strongly recommend that you stop accessing dp->dn and add your
> > own device tree parsing function during probe time. It is also a runtime
> > invariant, there is no reason to read the device tree during each mac_config.
> >
> What would be the correct way to pass all these data? Put all of them in
> qca8k_priv? Do we have a cleaner solution?

Put in driver private structures, or configure at probe time and never
modify touch again, anything goes.

Powered by blists - more mailing lists