[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 10 Oct 2021 15:50:02 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Ansuel Smith <ansuelsmth@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Matthew Hagan <mnhagan88@...il.com>
Subject: Re: [net-next PATCH v4 02/13] net: dsa: qca8k: add support for sgmii
falling edge
On Sun, Oct 10, 2021 at 02:10:00PM +0200, Ansuel Smith wrote:
> > I would strongly recommend that you stop accessing dp->dn and add your
> > own device tree parsing function during probe time. It is also a runtime
> > invariant, there is no reason to read the device tree during each mac_config.
> >
>
> What would be the correct way to pass all these data? Put all of them in
> qca8k_priv? Do we have a cleaner solution?
Put in driver private structures, or configure at probe time and never
modify touch again, anything goes.
Powered by blists - more mailing lists