linux-kernel - Re: [PATCH 2/2] arm/arm64: dts: Add MV88E6393X to CN9130-CRB device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWL8laRaWwordXdE@lunn.ch>
Date:   Sun, 10 Oct 2021 16:45:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "kostap@...vell.com" <kostap@...vell.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm/arm64: dts: Add MV88E6393X to CN9130-CRB device
 tree

> >> +			port@9 {
> >> +				reg = <9>;
> >> +				label = "wanp9";
> > Do these names correspond to some labeling? Ether the case or the silk
> > screen?
> The silkscreen just says P1-P8. I was tempted to rename "wan1" -> "lan1" 
> to match the others. I could also change them all to "pN" or "portN" if 
> preferred.

I normally say, use the labels from the case. That is what the user
sees. But if this RDK does not have case, then maybe lan1-lan8 would
be better, to match the silk screen. And then call port9 sfp1?

> P9 is connected to a SFP+ cage. I know there has been some work on the 
> bindings for that which I haven't caught up with.

Pretty simple. You need a node about the SFP itself:

sfp_eth3: sfp-eth3 {
        compatible = "sff,sfp";
        i2c-bus = <&sfp_1g_i2c>;
        los-gpios = <&cpm_gpio2 22 GPIO_ACTIVE_HIGH>;
        mod-def0-gpios = <&cpm_gpio2 21 GPIO_ACTIVE_LOW>;
        maximum-power-milliwatt = <1000>;
        pinctrl-names = "default";
        pinctrl-0 = <&cpm_sfp_1g_pins &cps_sfp_1g_pins>;
        tx-disable-gpios = <&cps_gpio1 24 GPIO_ACTIVE_HIGH>;
        tx-fault-gpios = <&cpm_gpio2 19 GPIO_ACTIVE_HIGH>;
};

If you don't have any of the GPIO, just don't list them.

And in the MAC you need to reference the sfp:

        sfp = <&sfp_eth3>;

Given that this is a marvell device, you might also need some comphy
configuration in the MAC node:

        phy-names = "comphy";
        phys = <&cps_comphy5 0>;

	Andrew