[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 10 Oct 2021 22:58:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Rob Herring <robh@...nel.org>
Cc: linux-nfc@...ts.01.org, devicetree@...r.kernel.org,
Jakub Kicinski <kuba@...nel.org>,
Mark Greer <mgreer@...malcreek.com>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>,
Charles Gorand <charles.gorand@...innov.com>
Subject: Re: [PATCH 1/7] dt-bindings: nfc: nxp,nci: convert to dtschema
On 10/10/2021 21:31, Rob Herring wrote:
> On Sun, 10 Oct 2021 16:23:11 +0200, Krzysztof Kozlowski wrote:
>> Convert the NXP NCI NFC controller to DT schema format.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>> ---
>> .../devicetree/bindings/net/nfc/nxp,nci.yaml | 61 +++++++++++++++++++
>> .../devicetree/bindings/net/nfc/nxp-nci.txt | 33 ----------
>> MAINTAINERS | 1 +
>> 3 files changed, 62 insertions(+), 33 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>> delete mode 100644 Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1539010
>
>
> nfc@28: 'clock-frequency' is a required property
> arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dt.yaml
>
Hmm, this actually looks as mistake in bindings. First, clock-frequency
is a property of a I2C bus, not I2C child device. Second, it should not
be a required property anyway, as I2C will choose a default one matching
driver (e.g. standard speed of 100 kHz).
Except the trf7970a NFC driver, none of other NFC drivers parse the
clock-frequency.
Best regards,
Krzysztof
Powered by blists - more mailing lists