linux-kernel - Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 16:51:37 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>,
        Denis Pauk <pauk.denis@...il.com>
Cc:     andy.shevchenko@...il.com, platform-driver-x86@...r.kernel.org,
        Tor Vic <torvic9@...lbox.org>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] hwmon: (asus_wmi_ec_sensors) Support B550 Asus
 WMI.

On 10/10/21 3:09 PM, Eugene Shalygin wrote:
>> Changes in v4:
>>   - implement wmi driver instead platform driver.
> 
> There are many ASUS boards where the required function is present but
> does nothing. With the WMI module alias the driver will be attempted
> to load for those boards (and rejected by the _probe() function). Is
> it a good thing?
> 

Drivers failing probe with -ENODEV (presumably here because dmi_check_system()
does not find a match) is pretty normal. Board detection with the WMI driver
seems much more straightforward/simple compared the previous version with
the platform driver. Maybe I am missing something, but I don't see a
problem with the WMI approach.

Guenter