[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 10 Oct 2021 09:50:23 +0300
From: Gal Pressman <galpress@...zon.com>
To: Christian König <christian.koenig@....com>,
Sumit Semwal <sumit.semwal@...aro.org>,
Doug Ledford <dledford@...hat.com>,
Jason Gunthorpe <jgg@...pe.ca>
CC: <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
Oded Gabbay <ogabbay@...ana.ai>,
Tomer Tayar <ttayar@...ana.ai>,
Yossi Leybovich <sleybo@...zon.com>,
Alexander Matushevsky <matua@...zon.com>,
Leon Romanovsky <leonro@...dia.com>,
Jianxin Xiong <jianxin.xiong@...el.com>,
Firas Jahjah <firasj@...zon.com>
Subject: Re: [RFC PATCH 1/2] dma-buf: Fix pin callback comment
On 07/10/2021 13:44, Christian König wrote:
> Am 07.10.21 um 12:42 schrieb Gal Pressman:
>> The pin callback does not necessarily have to move the memory to system
>> memory, remove the sentence from the comment.
>>
>> Signed-off-by: Gal Pressman <galpress@...zon.com>
>> ---
>> include/linux/dma-buf.h | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
>> index efdc56b9d95f..93830731a9a3 100644
>> --- a/include/linux/dma-buf.h
>> +++ b/include/linux/dma-buf.h
>> @@ -86,9 +86,7 @@ struct dma_buf_ops {
>> * @pin:
>> *
>> * This is called by dma_buf_pin() and lets the exporter know that the
>> - * DMA-buf can't be moved any more. The exporter should pin the buffer
>> - * into system memory to make sure it is generally accessible by other
>> - * devices.
>
> Maybe change that to something like "Ideally the exporter should pin the buffer
> so that it is generally accessible by all devices".
Sure, thanks.
Powered by blists - more mailing lists