linux-kernel - Re: [PATCH] ASoC: simple-card: Fill in driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 09:47:12 +0200
From:   Diederik de Haas <didi.debian@...ow.org>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Thierry Reding <treding@...dia.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Stephan Gerhold <stephan@...hold.net>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Guido Günther <agx@...xcpu.org>
Subject: Re: [PATCH] ASoC: simple-card: Fill in driver name

On Tuesday, 22 June 2021 10:27:09 CEST Guido Günther wrote:
> alsa-ucm groups by driver name so fill that in as well. Otherwise the
> presented information is redundant and doesn't reflect the used
> driver. We can't just use 'asoc-simple-card' since the driver name is
> restricted to 15 characters.
> 
> Before:
> 
>  # cat /proc/asound/cards
>  0 [Devkit         ]: Librem_5_Devkit - Librem 5 Devkit
>                       Librem 5 Devkit
> After:
> 
>  0 [Devkit         ]: simple-card - Librem 5 Devkit
>                       Librem 5 Devkit
> 
> Signed-off-by: Guido GÃ¼nther <agx@...xcpu.org>
> ---
> This came out of a discussion about adding alsa-ucm profiles for the
> Librem 5 Devkit at https://github.com/alsa-project/alsa-ucm-conf/pull/102
> 
>  sound/soc/generic/simple-card.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/generic/simple-card.c
> b/sound/soc/generic/simple-card.c index 0015f534d42d..a3a7990b5cb6 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -621,6 +621,7 @@ static int asoc_simple_probe(struct platform_device
> *pdev) card->owner		= THIS_MODULE;
>  	card->dev		= dev;
>  	card->probe		= simple_soc_probe;
> +	card->driver_name       = "simple-card";
> 
>  	li = devm_kzalloc(dev, sizeof(*li), GFP_KERNEL);
>  	if (!li)

Unfortunately this change broke multichannel audio on my Rock64 device running 
Debian. My Rock64 is connected to my AVR (Pioneer SC-1224) via a HDMI cable.

Before/without this change, pulseaudio correctly identifies my AVR and gives me 
hdmi-stereo/hdmi-surround/hdmi-surround71 output profiles via the HDMI card and 
iec958-stereo/iec958-ac3-surround-51 on my SPDIF card.
After/with this change, I only have a stereo-fallback output profile on both 
HDMI and SPDIF card.
I reported this to Debian at https://bugs.debian.org/995923
I have verified that reverting this commit on a self-built 5.14.10 brought back 
multichannel audio.

On LibreELEC's current nightly builds (version 11) with kernel 5.14 on 
a(nother) Rock64 device (also connected via HDMI cable), I hear no sound at 
all. Previous nightly builds (version 11) with I _assume_ kernel < 5.14, 
worked fine. As I didn't keep previous nightly builds, I can't verify that.
I reported that at https://github.com/LibreELEC/LibreELEC.tv/issues/5734
I have NOT verified whether reverting this commit would also restore audio with 
LibreELEC as I'm not familiar with their build system.

This is the first time I'm reporting an issue to the upstream Linux kernel, so 
I hope I did it correctly (DL-ed mbox file and did Reply-to-All). If not, 
apologies and I hope you'll point me to the correct place/way.
(I don't know if others need to be notified too as it is part of 5.14 releases)

Cheers,
  Diederik
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)