linux-kernel - Re: [PATCH] selftests: bpf: Remove dumplicated include in cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b1f31ec-68e4-92e1-f4a6-b97fcb3ba6a8@iogearbox.net>
Date:   Mon, 11 Oct 2021 16:30:04 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Wan Jiabing <wanjiabing@...o.com>, Shuah Khan <shuah@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, linux-kselftest@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kael_w@...h.net
Subject: Re: [PATCH] selftests: bpf: Remove dumplicated include in
 cgroup_helpers

On 10/11/21 1:19 PM, Wan Jiabing wrote:
> Fix following checkincludes.pl warning:
> ./tools/testing/selftests/bpf/cgroup_helpers.c
> 12	#include <unistd.h>
>      14	#include <unistd.h>

What does the 12 vs 14 mean here? Please provide a proper commit description, e.g. if
you used checkincludes.pl, maybe include the full command invocation and the relevant
output, so that this is more obvious and in a better shape. Thanks!

> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>   tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
> index 8fcd44841bb2..9d59c3990ca8 100644
> --- a/tools/testing/selftests/bpf/cgroup_helpers.c
> +++ b/tools/testing/selftests/bpf/cgroup_helpers.c
> @@ -11,7 +11,6 @@
>   #include <fcntl.h>
>   #include <unistd.h>
>   #include <ftw.h>
> -#include <unistd.h>
>   
>   #include "cgroup_helpers.h"
>   
>