linux-kernel - Re: [PATCH v3 4/8] net: phy: adin1100: Add initial support for ADIN1100 industrial PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211011082455.52c5532e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 Oct 2021 08:24:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <alexandru.tachici@...log.com>
Cc:     <andrew@...n.ch>, <o.rempel@...gutronix.de>, <davem@...emloft.net>,
        <devicetree@...r.kernel.org>, <hkallweit1@...il.com>,
        <linux-kernel@...r.kernel.org>, <linux@...linux.org.uk>,
        <netdev@...r.kernel.org>, <robh+dt@...nel.org>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>
Subject: Re: [PATCH v3 4/8] net: phy: adin1100: Add initial support for
 ADIN1100 industrial PHY

On Mon, 11 Oct 2021 17:22:11 +0300 alexandru.tachici@...log.com wrote:
> +/**
> + * struct adin_priv - ADIN PHY driver private data
> + * tx_level_2v4_able		set if the PHY supports 2.4V TX levels (10BASE-T1L)
> + * tx_level_2v4			set if the PHY requests 2.4V TX levels (10BASE-T1L)
> + * tx_level_prop_present	set if the TX level is specified in DT
> + */

This is not correct kdoc format. Should be

 * @member:	description

scripts/kernel-doc -none is your friend:

drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_2v4_able' not described in 'adin_priv'
drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_2v4' not described in 'adin_priv'
drivers/net/phy/adin1100.c:44: warning: Function parameter or member 'tx_level_prop_present' not described in 'adin_priv'