linux-kernel - Re: [PATCH v3 0/4] Merge contiguous physical memory regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0b1f070-e706-e298-e2fe-9a893870edc1@amazon.com>
Date:   Mon, 11 Oct 2021 18:47:19 +0300
From:   "Paraschiv, Andra-Irina" <andraprs@...zon.com>
To:     "Longpeng(Mike)" <longpeng2@...wei.com>
CC:     <arei.gonglei@...wei.com>, <gregkh@...uxfoundation.org>,
        <kamal@...onical.com>, <pbonzini@...hat.com>,
        <sgarzare@...hat.com>, <stefanha@...hat.com>,
        <vkuznets@...hat.com>, <linux-kernel@...r.kernel.org>,
        <ne-devel-upstream@...zon.com>, <lexnv@...zon.com>,
        <alcioa@...zon.com>
Subject: Re: [PATCH v3 0/4] Merge contiguous physical memory regions



On 09/10/2021 04:32, Longpeng(Mike) wrote:
> From: Longpeng <longpeng2@...wei.com>
> 
> Hi guys,
> 
> This patchset try to merge the contiguous physical memory regions when
> set user memory regions, you can see message in PATCH 1 for details.
> Please review when you free, thank!
> 
> Changes v2 -> v3:
>    Patch 1:
>      - update the commit title and commit message.  [Andra]
>      - use 'struct range' to instead of 'struct phys_mem_region'.  [Andra, Greg KH]
>      - add comments before the function definition.  [Andra]
>      - rename several variables, parameters and function.  [Andra]
>    Patch 2:
>      - update the commit title and commit message.  [Andra]
>      - add comments before the function definition.  [Andra]
>      - remove 'inline' attribute of ne_sanity_check_phys_mem_region. [Andra]
>      - leave a blank line before return.  [Andra]
>      - move sanity check in ne_merge_phys_contig_memory_regions to
>        the beginning of the function.  [Andra]
>      - double sanity checking after the merge of physical contiguous
>        memory regions has been completed.  [Andra]
>    Patch 3:
>      - update the commit title and commit message.  [Andra]
>      - use "misc_dev"/"misc device"/"MISC_DEV" to be more specific.  [Andra]
>    Patch 4:
>      - update the commit title and commit message.  [Andra]
>      - align the fileds in 'struct phys_regions_test'.  [Andra]
>      - rename 'phys_regions_testcases' to 'phys_regions_test_cases'.  [Andra]
>      - add comments before each test cases.  [Andra]
>      - initialize the variables in ne_misc_dev_test_merge_phys_contig_memory_regions.  [Andra]
> 
> Changes v1 -> v2:
>    - update the commit message as Andra's suggestion  [Andra]
>    - remove TODO completely in ne_set_user_memory_region_ioctl  [Andra]
>    - extract the physical memory regions setup into individual
>      function
>    - add kunit tests  [Andra]
> 
> Longpeng (4):
>    nitro_enclaves: Merge contiguous physical memory regions
>    nitro_enclaves: Sanity check physical memory regions during merging
>    nitro_enclaves: Add KUnit tests setup for the misc device
>      functionality
>    nitro_enclaves: Add KUnit tests for contiguous physical memory regions
>      merging
> 
>   drivers/virt/nitro_enclaves/Kconfig            |   9 ++
>   drivers/virt/nitro_enclaves/ne_misc_dev.c      | 163 +++++++++++++++++++------
>   drivers/virt/nitro_enclaves/ne_misc_dev_test.c | 153 +++++++++++++++++++++++
>   3 files changed, 285 insertions(+), 40 deletions(-)
>   create mode 100644 drivers/virt/nitro_enclaves/ne_misc_dev_test.c
> 

Thank you. I'll go through them till the end of this week.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.