lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Oct 2021 09:08:36 -0700 From: Raghavendra Rao Ananta <rananta@...gle.com> To: Marc Zyngier <maz@...nel.org> Cc: Paolo Bonzini <pbonzini@...hat.com>, Andrew Jones <drjones@...hat.com>, James Morse <james.morse@....com>, Alexandru Elisei <alexandru.elisei@....com>, Suzuki K Poulose <suzuki.poulose@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Peter Shier <pshier@...gle.com>, Ricardo Koller <ricarkol@...gle.com>, Oliver Upton <oupton@...gle.com>, Reiji Watanabe <reijiw@...gle.com>, Jing Zhang <jingzhangos@...gle.com>, linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu, linux-kernel@...r.kernel.org, kvm@...r.kernel.org Subject: Re: [PATCH v8 03/15] KVM: arm64: selftests: Use read/write definitions from sysreg.h Hi Marc, On Mon, Oct 11, 2021 at 1:15 AM Marc Zyngier <maz@...nel.org> wrote: > > Hi Raghavendra, > > On Fri, 08 Oct 2021 00:34:27 +0100, > Raghavendra Rao Ananta <rananta@...gle.com> wrote: > > > > Make use of the register read/write definitions from > > sysreg.h, instead of the existing definitions. A syntax > > correction is needed for the files that use write_sysreg() > > to make it compliant with the new (kernel's) syntax. > > > > Signed-off-by: Raghavendra Rao Ananta <rananta@...gle.com> > > Reviewed-by: Oliver Upton <oupton@...gle.com> > > Reviewed-by: Andrew Jones <drjones@...hat.com> > > --- > > .../selftests/kvm/aarch64/debug-exceptions.c | 28 +++++++++---------- > > .../selftests/kvm/include/aarch64/processor.h | 13 +-------- > > 2 files changed, 15 insertions(+), 26 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > index e5e6c92b60da..11fd23e21cb4 100644 > > --- a/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > +++ b/tools/testing/selftests/kvm/aarch64/debug-exceptions.c > > @@ -34,16 +34,16 @@ static void reset_debug_state(void) > > { > > asm volatile("msr daifset, #8"); > > > > - write_sysreg(osdlr_el1, 0); > > - write_sysreg(oslar_el1, 0); > > + write_sysreg(0, osdlr_el1); > > + write_sysreg(0, oslar_el1); > > The previous patch has obviously introduced significant breakage which > this patch is now fixing. In the interval, the build is broken, which > isn't great. > > You can either rework this series to work around the issue, or I can > squash patches #2 and #3 together. Thanks. I didn't realize this. I'm fine with you squashing the patches together (I guess I would do the same). Regards, Raghavendra > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.
Powered by blists - more mailing lists