linux-kernel - drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202110120138.kYJTjnMs-lkp@intel.com>
Date:   Tue, 12 Oct 2021 01:05:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom()
 warn: inconsistent indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
commit: 7958ba7e6273a02f49432a2506958d0f59b5b8da drivers: net: smsc: Add COMPILE_TEST support
date:   11 months ago
config: riscv-randconfig-m031-20211010 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

New smatch warnings:
drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting
drivers/net/ethernet/smsc/smc91x.c:2128 smc_request_attrib() warn: should '(64 * 1024) << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2141 smc_release_attrib() warn: should '(64 * 1024) << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2344 smc_drv_probe() warn: should '16 << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2434 smc_drv_remove() warn: should '16 << (lp->io_shift)' be a 64 bit type?

Old smatch warnings:
drivers/net/ethernet/smsc/smc91x.c:2403 smc_drv_probe() warn: should '16 << (lp->io_shift)' be a 64 bit type?

vim +1674 drivers/net/ethernet/smsc/smc911x.c

0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1655  
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1656  static int smc911x_ethtool_seteeprom(struct net_device *dev,
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1657  									   struct ethtool_eeprom *eeprom, u8 *data)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1658  {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1659  	int i, ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1660  
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1661  	/* Enable erase */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1662  	if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_EWEN_, 0 ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1663  		return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1664  	for(i=eeprom->offset;i<(eeprom->offset+eeprom->len);i++) {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1665  		/* erase byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1666  		if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_ERASE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1667  			return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1668  		/* write byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1669  		if ((ret=smc911x_ethtool_write_eeprom_byte(dev, *data))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1670  			 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1671  		if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_WRITE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1672  			return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1673  		}
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 @1674  	 return 0;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1675  }
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19  1676  

:::::: The code at line 1674 was first introduced by commit
:::::: 0a0c72c9118c4e63080eb409f0cfdf15808d23a4 [PATCH] RE: [PATCH 1/1] net driver: Add support for SMSC LAN911x line of ethernet chips

:::::: TO: Dustin McIntire <dustin@...soria.com>
:::::: CC: Jeff Garzik <jeff@...zik.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35150 bytes)