linux-kernel - Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffc6b1ef-02a8-83f0-b2e0-c03b6a1a4e0c@suse.cz>
Date:   Mon, 11 Oct 2021 09:54:27 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Gang Li <ligang.bdlg@...edance.com>, rostedt@...dmis.org
Cc:     mingo@...hat.com, akpm@...ux-foundation.org,
        axelrasmussen@...gle.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk

On 10/9/21 09:11, Gang Li wrote:
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
> 
> Signed-off-by: Gang Li <ligang.bdlg@...edance.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  include/trace/events/mmap_lock.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
>  	),
>  
>  	TP_printk(
> -		"mm=%p memcg_path=%s write=%s\n",
> +		"mm=%p memcg_path=%s write=%s",
>  		__entry->mm,
>  		__get_str(memcg_path),
>  		__entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
>  	),
>  
>  	TP_printk(
> -		"mm=%p memcg_path=%s write=%s success=%s\n",
> +		"mm=%p memcg_path=%s write=%s success=%s",
>  		__entry->mm,
>  		__get_str(memcg_path),
>  		__entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
>  	),
>  
>  	TP_printk(
> -		"mm=%p memcg_path=%s write=%s\n",
> +		"mm=%p memcg_path=%s write=%s",
>  		__entry->mm,
>  		__get_str(memcg_path),
>  		__entry->write ? "true" : "false"
>