linux-kernel - Re: [PATCH 13/13] ASoC: amd: enable yc machine driver build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d58fea8-cd45-c25d-300f-1e7438079c94@infradead.org>
Date:   Mon, 11 Oct 2021 00:55:26 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vijendar Mukunda <Vijendar.Mukunda@....com>, broonie@...nel.org,
        alsa-devel@...a-project.org
Cc:     Alexander.Deucher@....com, Basavaraj.Hiregoudar@....com,
        Sunil-kumar.Dommati@....com, Mario.Limonciello@....com,
        Richard.Gong@....com, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/13] ASoC: amd: enable yc machine driver build

On 10/10/21 10:56 PM, Vijendar Mukunda wrote:
> Enable YC platform dmic machine driver build.
> 
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@....com>
> ---
>   sound/soc/amd/Kconfig     | 7 +++++++
>   sound/soc/amd/yc/Makefile | 2 ++
>   2 files changed, 9 insertions(+)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 42825e8ad2ad..864d80f14421 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -67,3 +67,10 @@ config SND_SOC_AMD_ACP6x
>   	depends on X86 && PCI
>   	help
>   	 This option enables ACP v6.x DMIC support on AMD platform
> +

For the help text above here and the one below:

a. End the sentence with a period ('.').

b. Pay attention to the documented/accepted kernel style:

(from Documentation/process/coding-style.rst, section 10):

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.

> +config SND_SOC_AMD_YC_MACH
> +        tristate "AMD YC support for DMIC"
> +        select SND_SOC_DMIC
> +        depends on SND_SOC_AMD_ACP6x
> +        help
> +         This option enables machine driver for DMIC endpoint


thanks.
-- 
~Randy