linux-kernel - Re: [PATCH] crypto: octeontx2 - Use dma_alloc_coherent() instead of kzalloc/dma_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YWP4CbI7yENsP8/f@infradead.org>
Date:   Mon, 11 Oct 2021 09:38:33 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Boris Brezillon <bbrezillon@...nel.org>,
        Arnaud Ebalard <arno@...isbad.org>,
        Srujana Challa <schalla@...vell.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: octeontx2 - Use dma_alloc_coherent() instead of
 kzalloc/dma_map_single()

On Mon, Oct 11, 2021 at 12:00:04AM +0800, Cai Huoqing wrote:
> Replacing kzalloc/kfree/dma_map_single/dma_unmap_single()
> with dma_alloc_coherent/dma_free_coherent() helps to reduce
> code size, and simplify the code, and coherent DMA will not
> clear the cache every time.

As just explained in another patch like this please qualify the
savings as we have actual results that shows the reverse of your claims.