linux-kernel - Re: [PATCH v2] usb: misc: ehset: Workaround for "special" hubs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YWP5Z6IaD3blIfue@hovoldconsulting.com>
Date:   Mon, 11 Oct 2021 10:44:23 +0200
From:   Johan Hovold <johan@...nel.org>
To:     heghedus razvan <heghedus.razvan@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Chen <peter.chen@....com>,
        Anant Thazhemadam <anant.thazhemadam@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: misc: ehset: Workaround for "special" hubs

[ Please avoid top-posting. ]

On Thu, Oct 07, 2021 at 07:51:00PM +0300, heghedus razvan wrote:
> Hi all,
> 
> This was tested only with some external powered hubs. Indeed for the root
> hub there is
> a problem. I see that in the HCDs in hub_control there is the handling for
> testing
> procedures, but I don't know how they are used for the root hub.

This isn't just an issue with root hubs, the current implementation is
just completely broken for all hubs. Which begs the question of how you
tested this, if at all.

> I want to fix this problem, but I don't know how exactly, because I don't
> have a good
> grasp on the USB code since it's a huge beast. The main problem is how can I
> match the VID:PID of the hub_udev(the hub on which the USB testing device
> was connected) with the hub list for which I need to apply the quirk? I
> tried to
> use usb_match_id because I want to use functionality already in the kernel,
> but it seems that in this context I need to do the checking myself.

You can access the interfaces of a USB device through

	udev->actconfig->interface

but in this case it's probably better to just export
usb_device_match_id(), which seems to be what you need.

Johan