linux-kernel - Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux G070Y2-T02 panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 11 Oct 2021 11:01:48 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Robin van der Gracht <robin@...tonic.nl>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v1 2/3] drm: panel-simple: Add support for the Innolux
 G070Y2-T02 panel

On Sat, Oct 09, 2021 at 05:12:44PM +0200, Sam Ravnborg wrote:
> Hi Oleksij, Robin,
> 
> On Thu, Sep 30, 2021 at 12:05:00PM +0200, Oleksij Rempel wrote:
> > Add compatible and timings for the Innolux G070Y2-T02 panel. It is 7"
> > WVGA (800x480) TFT LCD panel with TTL interface and a backlight unit.
> > 
> > Co-Developed-by: Robin van der Gracht <robin@...tonic.nl>
> > Signed-off-by: Robin van der Gracht <robin@...tonic.nl>
> > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 9b6c4e6c38a1..a03b60f6fa99 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -2524,6 +2524,19 @@ static const struct panel_desc innolux_g070y2_l01 = {
> >  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> >  };
> >  
> > +static const struct panel_desc innolux_g070y2_t02 = {
> > +	.modes = &innolux_at070tn92_mode,
> 
> It is suprising to see that the innolux_g070y2_t02 uses the mode
> innolux_at070tn92_mode.
> Is it on purpose?

yes.

> If yes then I would expect the changelog to say so.
> 
> In most (all?) other cases the panel provide their own mode.

It works with same timing values. What is the preferred way, add own
mode or extend the changelog?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |