linux-kernel - Re: [axboe-block:perf-wip 13/20] drivers/block/rnbd/rnbd-clt.c:1226:27: error: initialization of 'int (*)(struct blk_mq_hw_ctx *, struct io_batch *)' from incompatible pointer type 'int (*)(struct blk_mq_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Oct 2021 05:56:20 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Gioh Kim <gi-oh.kim@...os.com>, Jinpu Wang <jinpu.wang@...os.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [axboe-block:perf-wip 13/20]
 drivers/block/rnbd/rnbd-clt.c:1226:27: error: initialization of 'int
 (*)(struct blk_mq_hw_ctx *, struct io_batch *)' from incompatible pointer
 type 'int (*)(struct blk_mq_hw_ctx *)'

On 10/11/21 2:58 AM, Gioh Kim wrote:
> On Fri, Oct 8, 2021 at 5:14 PM kernel test robot <lkp@...el.com> wrote:
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git perf-wip
>> head:   ba7751cd7411b7aaffd07728bd7cd6eeb890865d
>> commit: c5b891d342f43c8e486be3aeacd5ee61298d3561 [13/20] block: add a struct io_batch argument to fops->iopoll()
>> config: h8300-randconfig-r004-20211008 (attached as .config)
>> compiler: h8300-linux-gcc (GCC) 11.2.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=c5b891d342f43c8e486be3aeacd5ee61298d3561
>>         git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
>>         git fetch --no-tags axboe-block perf-wip
>>         git checkout c5b891d342f43c8e486be3aeacd5ee61298d3561
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>>> drivers/block/rnbd/rnbd-clt.c:1226:27: error: initialization of 'int (*)(struct blk_mq_hw_ctx *, struct io_batch *)' from incompatible pointer type 'int (*)(struct blk_mq_hw_ctx *)' [-Werror=incompatible-pointer-types]
>>     1226 |         .poll           = rnbd_rdma_poll,
>>          |                           ^~~~~~~~~~~~~~
>>    drivers/block/rnbd/rnbd-clt.c:1226:27: note: (near initialization for 'rnbd_mq_ops.poll')
>>    cc1: some warnings being treated as errors
>> --
>>>> drivers/nvme/host/tcp.c:2457:27: error: initialization of 'int (*)(struct blk_mq_hw_ctx *, struct io_batch *)' from incompatible pointer type 'int (*)(struct blk_mq_hw_ctx *)' [-Werror=incompatible-pointer-types]
>>     2457 |         .poll           = nvme_tcp_poll,
>>          |                           ^~~~~~~~~~~~~
>>    drivers/nvme/host/tcp.c:2457:27: note: (near initialization for 'nvme_tcp_mq_ops.poll')
>>    cc1: some warnings being treated as errors
>>
>>
>> vim +1226 drivers/block/rnbd/rnbd-clt.c
>>
>> 2958a995edc946 Gioh Kim  2021-04-19  1221
>> f7a7a5c228d45e Jack Wang 2020-05-11  1222  static struct blk_mq_ops rnbd_mq_ops = {
>> f7a7a5c228d45e Jack Wang 2020-05-11  1223       .queue_rq       = rnbd_queue_rq,
>> f7a7a5c228d45e Jack Wang 2020-05-11  1224       .complete       = rnbd_softirq_done_fn,
>> 2958a995edc946 Gioh Kim  2021-04-19  1225       .map_queues     = rnbd_rdma_map_queues,
>> 2958a995edc946 Gioh Kim  2021-04-19 @1226       .poll           = rnbd_rdma_poll,
>> f7a7a5c228d45e Jack Wang 2020-05-11  1227  };
>> f7a7a5c228d45e Jack Wang 2020-05-11  1228
>>
>> :::::: The code at line 1226 was first introduced by commit
>> :::::: 2958a995edc94654df690318df7b9b49e5a3ef88 block/rnbd-clt: Support polling mode for IO latency optimization
>>
>> :::::: TO: Gioh Kim <gi-oh.kim@...ud.ionos.com>
>> :::::: CC: Jens Axboe <axboe@...nel.dk>
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 
> 
> Hi Jens,
> 
> Regarding the warning email from the Kernel test robot as above,
> you might be able to fix it with the patch below.

I just missed this one originally, it's been fixed for a while in the
current tree.

-- 
Jens Axboe