linux-kernel - Re: [PATCH] ksmbd: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Oct 2021 21:19:32 +0900
From:   Hyunchul Lee <hyc.lee@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Namjae Jeon <linkinjeon@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steve French <sfrench@...ba.org>,
        linux-cifs <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ksmbd: Remove redundant 'flush_workqueue()' calls

Acked-by: Hyunchul Lee <hyc.lee@...il.com>

2021년 10월 10일 (일) 오후 10:29, Christophe JAILLET
<christophe.jaillet@...adoo.fr>님이 작성:
>
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> -       flush_workqueue(E);
>         destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  fs/ksmbd/ksmbd_work.c     | 1 -
>  fs/ksmbd/transport_rdma.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/fs/ksmbd/ksmbd_work.c b/fs/ksmbd/ksmbd_work.c
> index fd58eb4809f6..14b9caebf7a4 100644
> --- a/fs/ksmbd/ksmbd_work.c
> +++ b/fs/ksmbd/ksmbd_work.c
> @@ -69,7 +69,6 @@ int ksmbd_workqueue_init(void)
>
>  void ksmbd_workqueue_destroy(void)
>  {
> -       flush_workqueue(ksmbd_wq);
>         destroy_workqueue(ksmbd_wq);
>         ksmbd_wq = NULL;
>  }
> diff --git a/fs/ksmbd/transport_rdma.c b/fs/ksmbd/transport_rdma.c
> index 3a7fa23ba850..0fa7b9c17af3 100644
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -2026,7 +2026,6 @@ int ksmbd_rdma_destroy(void)
>         smb_direct_listener.cm_id = NULL;
>
>         if (smb_direct_wq) {
> -               flush_workqueue(smb_direct_wq);
>                 destroy_workqueue(smb_direct_wq);
>                 smb_direct_wq = NULL;
>         }
> --
> 2.30.2
>


-- 
Thanks,
Hyunchul