lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <13904686-9a74-00d9-d2fa-1ebf7e820d0c@gmail.com> Date: Sun, 10 Oct 2021 19:44:25 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Ansuel Smith <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>, Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [net-next PATCH v5 13/14] drivers: net: dsa: qca8k: set internal delay also for sgmii On 10/10/2021 6:30 PM, Ansuel Smith wrote: > QCA original code report port instability and sa that SGMII also require > to set internal delay. Generalize the rgmii delay function and apply the > advised value if they are not defined in DT. > > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com> > --- > drivers/net/dsa/qca8k.c | 81 +++++++++++++++++++++++++++-------------- > drivers/net/dsa/qca8k.h | 2 + > 2 files changed, 55 insertions(+), 28 deletions(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index cb66bdccc233..28635f4feaf5 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -998,6 +998,7 @@ qca8k_parse_port_config(struct qca8k_priv *priv) > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_TXID: > case PHY_INTERFACE_MODE_RGMII_RXID: > + case PHY_INTERFACE_MODE_SGMII: > delay = 0; > > if (!of_property_read_u32(port_dn, "tx-internal-delay-ps", &delay)) > @@ -1030,8 +1031,6 @@ qca8k_parse_port_config(struct qca8k_priv *priv) > > priv->rgmii_rx_delay[cpu_port_index] = delay; > > - break; > - case PHY_INTERFACE_MODE_SGMII: > if (of_property_read_bool(port_dn, "qca,sgmii-txclk-falling-edge")) > priv->sgmii_tx_clk_falling_edge = true; This also makes the RGMII* ports parse the couple of sgmii properties introduced earlier, but since these properties are only acted on for PHY_INTERFACE_MODE_SGMII in the .mac_config, I suppose that is fine. -- Florian
Powered by blists - more mailing lists