linux-kernel - Re: [PATCH 2/3] spi: bcm-qspi: clear MSPI spifie interrupt during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a9a6467-f9a3-1412-8063-e51d0e2c0e43@gmail.com>
Date:   Sun, 10 Oct 2021 19:53:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kamal Dasu <kdasu.kdev@...il.com>, broonie@...nel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     bcm-kernel-feedback-list@...adcom.com,
        yendapally.reddy@...adcom.com, Kamal Dasu <kdasu@...adcom.com>
Subject: Re: [PATCH 2/3] spi: bcm-qspi: clear MSPI spifie interrupt during
 probe



On 10/8/2021 1:36 PM, Kamal Dasu wrote:
> From: Kamal Dasu <kdasu@...adcom.com>
> 
> Intermittent Kernel crash has been observed on probe in
> bcm_qspi_mspi_l2_isr() handler when the MSPI spifie interrupt bit
> has not been cleared before registering for interrupts.
> Fix the driver to move SoC specific custom interrupt handling code
> before we register IRQ in probe. Also clear MSPI interrupt status
> resgiter prior to registering IRQ handlers.
> 
> Fixes: cc20a38612db ("spi: iproc-qspi: Add Broadcom iProc SoCs support")
> Signed-off-by: Kamal Dasu <kdasu@...adcom.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian