linux-kernel - Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 22:59:36 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Gang Li <ligang.bdlg@...edance.com>
Cc:     mingo@...hat.com, akpm@...ux-foundation.org, vbabka@...e.cz,
        axelrasmussen@...gle.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use
 DECLARE_EVENT_CLASS

On Mon, 11 Oct 2021 10:11:24 +0800
Gang Li <ligang.bdlg@...edance.com> wrote:

> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
> 
> By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot
> of space from duplicate code.

Why did you send this? It should be two patches, not one. The rule is,
every commit does one thing. Now you made this patch do two.

Andrew already pulled in the other two patches. I don't think this one
is appropriate, and should be discarded.

-- Steve


> 
> Signed-off-by: Gang Li <ligang.bdlg@...edance.com>