linux-kernel - Re: [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in vdpa_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07c02e3-e5eb-ae94-33d9-26c29de484c9@redhat.com>
Date:   Mon, 11 Oct 2021 11:04:14 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Wu Zongyong <wuzongyong@...ux.alibaba.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, mst@...hat.com
Cc:     wei.yang1@...ux.alibaba.com
Subject: Re: [PATCH v4 4/7] vdpa: add new callback get_vq_num_min in
 vdpa_config_ops


在 2021/9/29 下午2:11, Wu Zongyong 写道:
> This callback is optional. For vdpa devices that not support to change
> virtqueue size, get_vq_num_min and get_vq_num_max will return the same
> value, so that users can choose a correct value for that device.
>
> Suggested-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Wu Zongyong <wuzongyong@...ux.alibaba.com>


Acked-by: Jason Wang <jasowang@...hat.com>


> ---
>   include/linux/vdpa.h | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> index a896ee021e5f..30864848950b 100644
> --- a/include/linux/vdpa.h
> +++ b/include/linux/vdpa.h
> @@ -171,6 +171,9 @@ struct vdpa_map_file {
>    * @get_vq_num_max:		Get the max size of virtqueue
>    *				@vdev: vdpa device
>    *				Returns u16: max size of virtqueue
> + * @get_vq_num_min:		Get the min size of virtqueue (optional)
> + *				@vdev: vdpa device
> + *				Returns u16: min size of virtqueue
>    * @get_device_id:		Get virtio device id
>    *				@vdev: vdpa device
>    *				Returns u32: virtio device id
> @@ -266,6 +269,7 @@ struct vdpa_config_ops {
>   	void (*set_config_cb)(struct vdpa_device *vdev,
>   			      struct vdpa_callback *cb);
>   	u16 (*get_vq_num_max)(struct vdpa_device *vdev);
> +	u16 (*get_vq_num_min)(struct vdpa_device *vdev);
>   	u32 (*get_device_id)(struct vdpa_device *vdev);
>   	u32 (*get_vendor_id)(struct vdpa_device *vdev);
>   	u8 (*get_status)(struct vdpa_device *vdev);