linux-kernel - Re: [Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Oct 2021 08:02:58 +1000
From:   Ben Skeggs <skeggsb@...il.com>
To:     Karol Herbst <kherbst@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        DRI <dri-devel@...ts.freedesktop.org>,
        ML nouveau <nouveau@...ts.freedesktop.org>
Subject: Re: [Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable

On Tue, 12 Oct 2021 at 23:33, Karol Herbst <kherbst@...hat.com> wrote:
>
> Fixes a compilation issue introduced because I forgot to test with WERROR
> enabled.
>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: DRI <dri-devel@...ts.freedesktop.org>
> Cc: nouveau@...ts.freedesktop.org
> Fixes: 404046cf4805 ("drm/nouveau/mmu/gp100-: drop unneeded assignment in the if condition.")
> Signed-off-by: Karol Herbst <kherbst@...hat.com>
Reviewed-by: Ben Skeggs <bskeggs@...hat.com>

> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> index 2b21f43069aa..17899fc95b2d 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c
> @@ -488,7 +488,7 @@ gp100_vmm_fault_cancel(struct nvkm_vmm *vmm, void *argv, u32 argc)
>                 struct gp100_vmm_fault_cancel_v0 v0;
>         } *args = argv;
>         int ret = -ENOSYS;
> -       u32 inst, aper;
> +       u32 aper;
>
>         if ((ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false)))
>                 return ret;
> --
> 2.31.1
>