linux-kernel - Re: [RFC][PATCH] iommu: Kconfig: Fix missing config option for CONFIG_ARM_SMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YWUDAoDoPPewqcdO@yoga>
Date:   Mon, 11 Oct 2021 22:37:38 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
        Amit Pundir <amit.pundir@...aro.org>,
        Caleb Connolly <caleb.connolly@...aro.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [RFC][PATCH] iommu: Kconfig: Fix missing config option for
 CONFIG_ARM_SMMU_QCOM

On Mon 11 Oct 22:26 CDT 2021, John Stultz wrote:

> In commit 424953cf3c665 ("qcom_scm: hide Kconfig symbol"), some
> logic was added to make the code depend on CONFIG_ARM_SMMU_QCOM,
> however no such option exist.
> 
> This caused regressions on db845c (and I suspect other qcom
> platforms), but can be easily fixed up by adding a new option
> to re-enable the newly conditionalized code.
> 
> I set it to default to ARCH_QCOM, so folks don't have to
> discover this new option to keep things booting, but if folks
> would rather, I'm ok to drop that line.
> 

I've not looked where the discussion went, but Dmitry posted this end of
last week:

https://lore.kernel.org/linux-arm-msm/20211010023350.978638-1-dmitry.baryshkov@linaro.org/

Regards,
Bjorn

> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Amit Pundir <amit.pundir@...aro.org>
> Cc: Caleb Connolly <caleb.connolly@...aro.org>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
> Cc: linux-arm-msm <linux-arm-msm@...r.kernel.org>
> Fixes: 424953cf3c665 ("qcom_scm: hide Kconfig symbol")
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  drivers/iommu/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index c5c71b7ab7e83..e674796b1174d 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -380,6 +380,16 @@ config ARM_SMMU_V3_SVA
>  	  Say Y here if your system supports SVA extensions such as PCIe PASID
>  	  and PRI.
>  
> +config ARM_SMMU_QCOM
> +	bool "QCOM Specific ARM SMMU implementation support"
> +	depends on ARM_SMMU
> +	default ARCH_QCOM
> +	help
> +          Support for the QCOM implementation of the ARM System MMU architecture.
> +
> +          Say Y here if your SoC includes an QCOM IOMMU device implementing
> +          the ARM SMMU architecture.
> +
>  config S390_IOMMU
>  	def_bool y if S390 && PCI
>  	depends on S390 && PCI
> -- 
> 2.25.1
>