linux-kernel - Re: [PATCH v1] Bluetooth: btusb: Add support for variant WCN6855 by using different nvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 12 Oct 2021 14:30:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     tjiang@...eaurora.org, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org, c-hbandi@...eaurora.org,
        hemantg@...eaurora.org, mka@...omium.org
Subject: Re: [PATCH v1] Bluetooth: btusb: Add support for variant WCN6855 by
 using  different nvm

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on linux/master linus/master v5.15-rc5 next-20211011]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/tjiang-codeaurora-org/Bluetooth-btusb-Add-support-for-variant-WCN6855-by-using-different-nvm/20211011-184940
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: openrisc-randconfig-s032-20211011 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/ac46dc5565c49861c2439a5534e2e64ff819eb60
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review tjiang-codeaurora-org/Bluetooth-btusb-Add-support-for-variant-WCN6855-by-using-different-nvm/20211011-184940
        git checkout ac46dc5565c49861c2439a5534e2e64ff819eb60
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/bluetooth/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   drivers/bluetooth/btusb.c:1900:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1900:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1900:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1900:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1904:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1904:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1904:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1904:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1908:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1908:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1908:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1908:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1912:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1912:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1912:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1912:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1916:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1916:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1916:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1916:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1922:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1922:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1922:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:1922:18: sparse: sparse: cast to restricted __le16
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3359:28: sparse: sparse: cast to restricted __le32
   drivers/bluetooth/btusb.c:3388:18: sparse: sparse: restricted __le16 degrades to integer
>> drivers/bluetooth/btusb.c:3392:28: sparse: sparse: restricted __le32 degrades to integer
>> drivers/bluetooth/btusb.c:3392:28: sparse: sparse: restricted __le32 degrades to integer

vim +3392 drivers/bluetooth/btusb.c

  3381	
  3382	static void btusb_generate_qca_nvm_name(char *fwname,
  3383						size_t max_size,
  3384						struct qca_version *ver)
  3385	{
  3386		u32 rom_version = le32_to_cpu(ver->rom_version);
  3387	
  3388		if (((ver->flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {
  3389			u16 board_id = le16_to_cpu(ver->board_id);
  3390			const char *variant;
  3391	
> 3392			switch (ver->ram_version) {
  3393			case WCN6855_2_0_RAM_VERSION_GF:
  3394			case WCN6855_2_1_RAM_VERSION_GF:
  3395				variant = "_gf";
  3396				break;
  3397			default:
  3398				variant = "";
  3399				break;
  3400			}
  3401	
  3402			/* if boardid equal 0, use default nvm without suffix */
  3403			if (board_id == 0x0) {
  3404				snprintf(fwname, max_size, "qca/nvm_usb_%08x%s.bin",
  3405					rom_version, variant);
  3406			} else {
  3407				snprintf(fwname, max_size, "qca/nvm_usb_%08x%s_%04x.bin",
  3408					rom_version, variant, board_id);
  3409			}
  3410		} else {
  3411			snprintf(fwname, max_size, "qca/nvm_usb_%08x.bin",
  3412				rom_version);
  3413		}
  3414	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37823 bytes)