linux-kernel - Re: [PATCH] tracing: Fix event probe removal from dynamic events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202110121600.rCLj6mgL-lkp@intel.com>
Date:   Tue, 12 Oct 2021 16:29:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     kbuild-all@...ts.01.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tom Zanussi <zanussi@...nel.org>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>,
        Yordan Karadzhov <y.karadz@...il.com>
Subject: Re: [PATCH] tracing: Fix event probe removal from dynamic events

Hi Steven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on hnaz-mm/master linus/master v5.15-rc5 next-20211011]
[cannot apply to tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Steven-Rostedt/tracing-Fix-event-probe-removal-from-dynamic-events/20211012-091238
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5816b3e6577eaa676ceb00a848f0fd65fe2adc29
config: parisc-randconfig-r006-20211011 (attached as .config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4d930af6a4aa75558017f921e2c9692ed27b2c56
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Steven-Rostedt/tracing-Fix-event-probe-removal-from-dynamic-events/20211012-091238
        git checkout 4d930af6a4aa75558017f921e2c9692ed27b2c56
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/trace/trace_eprobe.c: In function 'eprobe_dyn_event_match':
>> kernel/trace/trace_eprobe.c:128:9: error: 'slash' undeclared (first use in this function)
     128 |         slash = strchr(argv[0], '/');
         |         ^~~~~
   kernel/trace/trace_eprobe.c:128:9: note: each undeclared identifier is reported only once for each function it appears in


vim +/slash +128 kernel/trace/trace_eprobe.c

   117	
   118	static bool eprobe_dyn_event_match(const char *system, const char *event,
   119				int argc, const char **argv, struct dyn_event *ev)
   120	{
   121		struct trace_eprobe *ep = to_trace_eprobe(ev);
   122	
   123		/* First argument is the system/event the probe is attached to */
   124	
   125		if (argc < 1)
   126			return false;
   127	
 > 128		slash = strchr(argv[0], '/');
   129		if (!slash)
   130			slash = strchr(argv[0], '.');
   131		if (!slash)
   132			return false;
   133	
   134		if (strncmp(ep->event_system, argv[0], slash - argv[0]))
   135			return false;
   136		if (strcmp(ep->event_name, slash + 1))
   137			return false;
   138	
   139		argc--;
   140		argv++;
   141	
   142		return strcmp(trace_probe_name(&ep->tp), event) == 0 &&
   143		    (!system || strcmp(trace_probe_group_name(&ep->tp), system) == 0) &&
   144		    trace_probe_match_command_args(&ep->tp, argc, argv);
   145	}
   146	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (32676 bytes)