[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b2355acf-94a5-1acf-122b-d661c6d9bb1b@canonical.com>
Date: Tue, 12 Oct 2021 10:32:45 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Luca Ceresoli <luca@...aceresoli.net>, linux-kernel@...r.kernel.org
Cc: Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
Chiwoong Byun <woong.byun@...sung.com>,
Laxman Dewangan <ldewangan@...dia.com>
Subject: Re: [PATCH 6/8] mfd: max77714: Add driver for Maxim MAX77714 PMIC
On 11/10/2021 17:56, Luca Ceresoli wrote:
> Add a simple driver for the Maxim MAX77714 PMIC, supporting RTC and
> watchdog only.
>
> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
> ---
> MAINTAINERS | 2 +
> drivers/mfd/Kconfig | 14 ++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/max77714.c | 151 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/max77714.h | 68 ++++++++++++++++
> 5 files changed, 236 insertions(+)
> create mode 100644 drivers/mfd/max77714.c
> create mode 100644 include/linux/mfd/max77714.h
>
(...)
> +
> +static const struct of_device_id max77714_dt_match[] = {
> + { .compatible = "maxim,max77714" },
> + {},
> +};
When converting to module - don't forget the MODULE_DEVICE_TABLE
> +
> +static struct i2c_driver max77714_driver = {
> + .driver = {
> + .name = "max77714",
> + .of_match_table = of_match_ptr(max77714_dt_match),
Kbuild robot pointed it out - of_matc_ptr should not be needed, even for
compile testing without OF.
> + },
> + .probe_new = max77714_probe,
> +};
Best regards,
Krzysztof
Powered by blists - more mailing lists