linux-kernel - Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk0ii397m.wl-tiwai@suse.de>
Date:   Tue, 12 Oct 2021 11:04:29 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Jonas Hahnfeld <hahnjo@...njo.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770

On Mon, 11 Oct 2021 19:12:56 +0200,
Jonas Hahnfeld wrote:
> 
> Am Sonntag, dem 10.10.2021 um 22:26 +0200 schrieb Takashi Iwai:
> > On Sun, 10 Oct 2021 13:19:47 +0200,
> > Jonas Hahnfeld wrote:
> > > 
> > > The device advertises 8 formats, but only a rate of 48kHz is honored
> > > by the hardware and 24 bits give chopped audio, so only report the
> > > one working combination. This fixes out-of-the-box audio experience
> > > with PipeWire which otherwise attempts to choose S24_3LE (while
> > > PulseAudio defaulted to S16_LE).
> > > 
> > > Signed-off-by: Jonas Hahnfeld <hahnjo@...njo.de>
> > 
> > Could you give alsa-info.sh output with and without patch, just for
> > comparison?  Run the script with --no-upload option and attach the
> > outputs.
> 
> Attached. Let me know if I should put any of this into the commit
> message.

Thanks.  The device is a UAC1, so the format quirk seems to be a valid
way.

But I found the terminator entry (.ifnum = -1) is missing in the
QUIRK_COMPOSITE array.  Could you resubmit with the fix?


thanks,

Takashi