linux-kernel - RE: [PATCH v4 2/4] perf/marvell: CN10k DDR performance monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY4PR1801MB2070C952470F81D26C1BB43ADEB69@CY4PR1801MB2070.namprd18.prod.outlook.com>
Date:   Tue, 12 Oct 2021 09:16:13 +0000
From:   Bhaskara Budiredla <bbudiredla@...vell.com>
To:     Bharat Bhushan <bbhushan2@...vell.com>,
        "will@...nel.org" <will@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 2/4] perf/marvell: CN10k DDR performance monitor
 support


[...]

>>
>> v2->v3:
>>  - Add COMPILE_TEST as a dependency

This is missing.

>>  - Switch to sysfs_emit()
>>  - Error propagation when invalif event requested
>>  - Switch to devm_platform_get_and_ioremap_resource()
>>  - Other review comments on v2.
>>
>> v1->v2:
>>   - writeq/readq changed to respective relaxed version
>>   - Using PMU_EVENT_ATTR_ID
>>
>>  drivers/perf/Kconfig                 |   7 +
>>  drivers/perf/Makefile                |   1 +
>>  drivers/perf/marvell_cn10k_ddr_pmu.c | 599
>> +++++++++++++++++++++++++++
>>  3 files changed, 607 insertions(+)
>>  create mode 100644 drivers/perf/marvell_cn10k_ddr_pmu.c
>>
>> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index
>> 77522e5efe11..41a80a4b8d29 100644
>> --- a/drivers/perf/Kconfig
>> +++ b/drivers/perf/Kconfig
>> @@ -139,4 +139,11 @@ config ARM_DMC620_PMU
>>
>>  source "drivers/perf/hisilicon/Kconfig"
>>
>> +config MARVELL_CN10K_DDR_PMU
>> +	tristate "Enable MARVELL CN10K DRAM Subsystem(DSS) PMU
>Support"
>> +	depends on ARM64
>> +	help
>> +	  Enable perf support for Marvell DDR Performance monitoring
>> +	  event on CN10K platform.
>> +
>>  endmenu