linux-kernel - Re: [PATCH] drm: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Oct 2021 16:27:41 +0300
From:   Jyri Sarha <jyri.sarha@....fi>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     l.stach@...gutronix.de, linux+etnaviv@...linux.org.uk,
        christian.gmeiner@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        robdclark@...il.com, sean@...rly.run, tomba@...nel.org,
        linux-graphics-maintainer@...are.com, zackr@...are.com,
        linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
        etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm: Remove redundant 'flush_workqueue()' calls

On 2021-10-10 16:59, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

For tilcdc
Acked-by: Jyri Sarha <jyri.sarha@....fi>

Thanks,
Jyri

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
>  drivers/gpu/drm/msm/dsi/dsi_host.c    | 1 -
>  drivers/gpu/drm/msm/edp/edp_ctrl.c    | 1 -
>  drivers/gpu/drm/msm/hdmi/hdmi.c       | 4 +---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c   | 4 +---
>  drivers/gpu/drm/vmwgfx/ttm_memory.c   | 1 -
>  6 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 789acae37f55..06bde46df451 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1733,7 +1733,6 @@ static void etnaviv_gpu_unbind(struct device
> *dev, struct device *master,
> 
>  	DBG("%s", dev_name(gpu->dev));
> 
> -	flush_workqueue(gpu->wq);
>  	destroy_workqueue(gpu->wq);
> 
>  	etnaviv_sched_fini(gpu);
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index c86b5090fae6..462ea65ebf89 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1925,7 +1925,6 @@ void msm_dsi_host_destroy(struct mipi_dsi_host 
> *host)
>  	DBG("");
>  	dsi_tx_buf_free(msm_host);
>  	if (msm_host->workqueue) {
> -		flush_workqueue(msm_host->workqueue);
>  		destroy_workqueue(msm_host->workqueue);
>  		msm_host->workqueue = NULL;
>  	}
> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> index fe1366b4c49f..07129a6e5dbb 100644
> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> @@ -1190,7 +1190,6 @@ void msm_edp_ctrl_destroy(struct edp_ctrl *ctrl)
>  		return;
> 
>  	if (ctrl->workqueue) {
> -		flush_workqueue(ctrl->workqueue);
>  		destroy_workqueue(ctrl->workqueue);
>  		ctrl->workqueue = NULL;
>  	}
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c 
> b/drivers/gpu/drm/msm/hdmi/hdmi.c
> index 737453b6e596..5ba7c8f28419 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
> @@ -61,10 +61,8 @@ static void msm_hdmi_destroy(struct hdmi *hdmi)
>  	 * at this point, hpd has been disabled,
>  	 * after flush workq, it's safe to deinit hdcp
>  	 */
> -	if (hdmi->workq) {
> -		flush_workqueue(hdmi->workq);
> +	if (hdmi->workq)
>  		destroy_workqueue(hdmi->workq);
> -	}
>  	msm_hdmi_hdcp_destroy(hdmi);
> 
>  	if (hdmi->phy_dev) {
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 6b03f89a98d4..3ddb7c710a3d 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -186,10 +186,8 @@ static void tilcdc_fini(struct drm_device *dev)
>  	if (priv->mmio)
>  		iounmap(priv->mmio);
> 
> -	if (priv->wq) {
> -		flush_workqueue(priv->wq);
> +	if (priv->wq)
>  		destroy_workqueue(priv->wq);
> -	}
> 
>  	dev->dev_private = NULL;
> 
> diff --git a/drivers/gpu/drm/vmwgfx/ttm_memory.c
> b/drivers/gpu/drm/vmwgfx/ttm_memory.c
> index edd17c30d5a5..7f7fe35fc21d 100644
> --- a/drivers/gpu/drm/vmwgfx/ttm_memory.c
> +++ b/drivers/gpu/drm/vmwgfx/ttm_memory.c
> @@ -468,7 +468,6 @@ void ttm_mem_global_release(struct ttm_mem_global 
> *glob)
>  	struct ttm_mem_zone *zone;
>  	unsigned int i;
> 
> -	flush_workqueue(glob->swap_queue);
>  	destroy_workqueue(glob->swap_queue);
>  	glob->swap_queue = NULL;
>  	for (i = 0; i < glob->num_zones; ++i) {