linux-kernel - Re: [PATCH v2 2/2] mm: use pidfd_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b91f642b-2b64-a60c-89e2-0317164c7b70@redhat.com>
Date:   Tue, 12 Oct 2021 16:13:31 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Christian Brauner <brauner@...nel.org>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Matthew Bobrowski <repnop@...gle.com>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Jan Kara <jack@...e.cz>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH v2 2/2] mm: use pidfd_get_task()

On 11.10.21 15:32, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@...ntu.com>
> 
> Instead of duplicating the same code in two places use the newly added
> pidfd_get_task() helper. This fixes an (unimportant for now) bug where
> PIDTYPE_PID is used whereas PIDTYPE_TGID should have been used.

What would have been the effect of the BUG? Is it worth Fixes: or better 
even separating out the fix?

> 
> Link: https://lore.kernel.org/r/20211004125050.1153693-3-christian.brauner@ubuntu.com
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Cc: Matthew Bobrowski <repnop@...gle.com>
> Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Minchan Kim <minchan@...nel.org>
> Reviewed-by: Matthew Bobrowski <repnop@...gle.com>
> Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> ---
> /* v2 */
> unchanged

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb